refactor(ui): move Segments to use Redux storage #2441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2441 +/- ##
=======================================
Coverage 70.76% 70.76%
=======================================
Files 81 81
Lines 8110 8110
=======================================
Hits 5739 5739
Misses 2025 2025
Partials 346 346 ☔ View full report in Codecov by Sentry. |
markphelps
reviewed
Nov 24, 2023
authorized response. make eslint more happy
markphelps
reviewed
Nov 26, 2023
| @@ -61,12 +61,10 @@ export default function Rules() { | |||
| const namespace = useSelector(selectCurrentNamespace); | |||
| const readOnly = useSelector(selectReadonly); | |||
|
|
|||
| const segments = useListSegmentsQuery(namespace.key)?.data?.segments || []; | |||
|
|
|||
There was a problem hiding this comment.
@erka is this something to worry about? ☝🏻
There was a problem hiding this comment.
I modified the code to address it.
markphelps
reviewed
Nov 26, 2023
This was referenced Nov 26, 2023
markphelps
approved these changes
Nov 26, 2023
|
Theres currently something broken with our fs/git integration tests on main, looking into it now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to use Redux RTK for Segments.
listSegmentsRefs: #2433