Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: no value bug for boolean constraint type #2395

Merged
merged 2 commits into from
Nov 14, 2023

Conversation

markphelps
Copy link
Collaborator

Fixes: #2389

2023-11-14 11 02 27

@markphelps markphelps requested a review from a team as a code owner November 14, 2023 16:06
@markphelps markphelps enabled auto-merge (squash) November 14, 2023 16:08
Copy link
Contributor

github-actions bot commented Nov 14, 2023

Uffizzi Preview deployment-40728 was deleted.

Copy link

codecov bot commented Nov 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f6912e1) 70.82% compared to head (6a84ace) 70.82%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2395   +/-   ##
=======================================
  Coverage   70.82%   70.82%           
=======================================
  Files          81       81           
  Lines        8103     8103           
=======================================
  Hits         5739     5739           
  Misses       2018     2018           
  Partials      346      346           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@markphelps markphelps disabled auto-merge November 14, 2023 16:26
@markphelps markphelps merged commit b88b9ad into main Nov 14, 2023
@markphelps markphelps deleted the constraint-boolean-bug-fix branch November 14, 2023 16:26
markphelps added a commit that referenced this pull request Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Boolean constraint type asks for value when you switch operator
3 participants