Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: db root on mac after refactor #2373

Merged
merged 11 commits into from
Nov 13, 2023
Merged

fix: db root on mac after refactor #2373

merged 11 commits into from
Nov 13, 2023

Conversation

markphelps
Copy link
Collaborator

Fixes DB root default for macOS/sqlite after refactor in https://github.com/flipt-io/flipt/pull/2328/files#diff-ed20782674601a14492cbd695a5a98da407c0bc124a98af34dcc9a7411254d10

also adds SQLite test workflow for macOS

@markphelps markphelps requested a review from a team as a code owner November 12, 2023 18:13
Copy link
Contributor

github-actions bot commented Nov 12, 2023

Uffizzi Preview deployment-40610 was deleted.

Copy link

codecov bot commented Nov 12, 2023

Codecov Report

Merging #2373 (6f08e12) into main (8382bd2) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2373   +/-   ##
=======================================
  Coverage   70.46%   70.46%           
=======================================
  Files          81       81           
  Lines        7969     7969           
=======================================
  Hits         5615     5615           
  Misses       2010     2010           
  Partials      344      344           
Files Coverage Δ
internal/config/config.go 86.74% <100.00%> (ø)
internal/config/database.go 91.66% <100.00%> (ø)
internal/config/database_linux.go 100.00% <100.00%> (ø)

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@markphelps markphelps requested a review from GeorgeMac November 12, 2023 19:11
Copy link
Member

@GeorgeMac GeorgeMac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! 🙇

@markphelps markphelps enabled auto-merge (squash) November 13, 2023 12:11
@markphelps markphelps merged commit 0571dff into main Nov 13, 2023
34 checks passed
@markphelps markphelps deleted the fix-db-root-mac branch November 13, 2023 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants