Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: supporting namespaced auth tokens #2352

Merged
merged 81 commits into from
Nov 14, 2023
Merged

feat: supporting namespaced auth tokens #2352

merged 81 commits into from
Nov 14, 2023

Conversation

markphelps
Copy link
Collaborator

@markphelps markphelps commented Nov 7, 2023

Fixes: #2287

  • Adds support for namespaced tokens for flipt.Server and evaluation.Server ONLY. Will need to mention this in the docs, and likely link to these docs in this new UI
  • Moves grpc and HTTP auth middleware to their own subpackages
  • adds missing read_only config to config schemas

Copy link
Contributor

github-actions bot commented Nov 7, 2023

Uffizzi Preview deployment-40711 was deleted.

Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Attention: 24 lines in your changes are missing coverage. Please review.

Comparison is base (381b90f) 70.57% compared to head (d70f79b) 70.82%.

Files Patch % Lines
internal/cmd/auth.go 0.00% 13 Missing ⚠️
internal/server/auth/middleware/grpc/middleware.go 95.55% 3 Missing and 1 partial ⚠️
internal/cmd/grpc.go 0.00% 3 Missing ⚠️
internal/server/auth/server.go 71.42% 2 Missing ⚠️
internal/server/server.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2352      +/-   ##
==========================================
+ Coverage   70.57%   70.82%   +0.24%     
==========================================
  Files          81       81              
  Lines        8011     8103      +92     
==========================================
+ Hits         5654     5739      +85     
- Misses       2012     2018       +6     
- Partials      345      346       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@markphelps markphelps changed the title feat(wip): beginnings of supporting namespaced auth tokens feat: beginnings of supporting namespaced auth tokens Nov 9, 2023
@markphelps
Copy link
Collaborator Author

Help me @GeorgeMac , you're my only hope

@GeorgeMac
Copy link
Member

r2d2

@markphelps markphelps requested a review from GeorgeMac November 14, 2023 15:00
Copy link
Member

@GeorgeMac GeorgeMac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What a journey 🚗

@markphelps
Copy link
Collaborator Author

What a journey 🚗

The real journey was all the friends we made along the way or something

@markphelps markphelps enabled auto-merge (squash) November 14, 2023 15:20
@markphelps markphelps merged commit d6b83dd into main Nov 14, 2023
31 checks passed
@markphelps markphelps deleted the namespace-auth-token branch November 14, 2023 15:33
markphelps added a commit that referenced this pull request Nov 14, 2023
@markphelps markphelps removed the needs docs Requires documentation updates label Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FLI-665] [Feature Request] Namespace scoped static tokens
3 participants