Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add flag key to variant and boolean evaluation responses #2318

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

yquansah
Copy link
Contributor

@yquansah yquansah commented Oct 31, 2023

Add flagKey to the Variant and Boolean evaluation responses. This in turn will add the same flagKey to the Batch evaluation responses.

Will complete the following issue.

Fixes: #2302

@github-actions
Copy link
Contributor

github-actions bot commented Oct 31, 2023

Uffizzi Ephemeral Environment deployment-39832

☁️ https://app.uffizzi.com/github.com/flipt-io/flipt/pull/2318

📄 View Application Logs etc.

⏰ This Preview will be destroyed in 1 hours at: Tue Oct 31 04:37:05 UTC 2023

What is Uffizzi? Learn more!

@codecov
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Merging #2318 (d55f512) into main (7ee465f) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2318      +/-   ##
==========================================
+ Coverage   70.85%   70.87%   +0.01%     
==========================================
  Files          78       78              
  Lines        7432     7436       +4     
==========================================
+ Hits         5266     5270       +4     
  Misses       1866     1866              
  Partials      300      300              
Files Coverage Δ
internal/server/evaluation/evaluation.go 90.72% <100.00%> (+0.15%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@markphelps markphelps added the automerge Used by Kodiak bot to automerge PRs label Oct 31, 2023
@kodiakhq kodiakhq bot merged commit e88e939 into main Oct 31, 2023
32 checks passed
@kodiakhq kodiakhq bot deleted the add-flag-key-batch branch October 31, 2023 13:00
@kodiakhq kodiakhq bot temporarily deployed to uffizzi October 31, 2023 13:01 Inactive
@markphelps markphelps added the needs docs Requires documentation updates label Oct 31, 2023
markphelps added a commit that referenced this pull request Oct 31, 2023
* 'main' of https://github.com/flipt-io/flipt:
  feat: add flag key to variant and boolean evaluation responses (#2318)
  chore(deps): bump github.com/aws/aws-sdk-go-v2/config (#2310)
  chore(deps): bump github.com/redis/go-redis/v9 from 9.2.0 to 9.2.1 (#2309)
markphelps added a commit that referenced this pull request Nov 1, 2023
* main:
  feat: add LiteFS example for Flipt in the examples directory (#2297)
  docs: add legoheld as a contributor for code (#2321)
  chore: update Clients in readme (#2320)
  chore: prep v1.30 (#2319)
  chore(deps): bump github.com/docker/docker in /_tools (#2314)
  chore(deps): bump github.com/docker/docker in /build (#2315)
  feat: add flag key to variant and boolean evaluation responses (#2318)
  chore(deps): bump github.com/aws/aws-sdk-go-v2/config (#2310)
  chore(deps): bump github.com/redis/go-redis/v9 from 9.2.0 to 9.2.1 (#2309)
@markphelps markphelps removed the needs docs Requires documentation updates label Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Used by Kodiak bot to automerge PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Add flag key to batch evaluation response
3 participants