Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache Everything #215

Merged
merged 23 commits into from
Feb 1, 2020
Merged

Cache Everything #215

merged 23 commits into from
Feb 1, 2020

Conversation

markphelps
Copy link
Collaborator

Fixes: #100

Adds ability for in-memory cache for all reads

@codecov-io
Copy link

codecov-io commented Feb 1, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@7a9879b). Click here to learn what that means.
The diff coverage is 87.16%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #215   +/-   ##
=========================================
  Coverage          ?   85.54%           
=========================================
  Files             ?       18           
  Lines             ?     1681           
  Branches          ?        0           
=========================================
  Hits              ?     1438           
  Misses            ?      160           
  Partials          ?       83
Impacted Files Coverage Δ
storage/cache/cache.go 0% <0%> (ø)
config/config.go 89.58% <100%> (ø)
storage/db/segment.go 82.29% <100%> (ø)
storage/cache/segment.go 90.16% <100%> (ø)
storage/db/evaluation.go 79.22% <100%> (ø)
server/evaluator.go 90.76% <100%> (ø)
server/flag.go 100% <100%> (ø)
storage/db/rule.go 75.2% <100%> (ø)
server/rule.go 100% <100%> (ø)
storage/db/flag.go 81.69% <100%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a9879b...c0ac363. Read the comment docs.

@markphelps markphelps merged commit 86eaa3f into master Feb 1, 2020
@markphelps markphelps deleted the cache-redo branch February 1, 2020 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rule evaluation caching
2 participants