Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(segments): introduce cue validation for new segment definitions #2000

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

yquansah
Copy link
Contributor

Introduce new cue definitions for rule and rollout segment definitions. Also, add new tests to validate the new behavior of the updated cue file.

Completes FLI-548

@yquansah yquansah requested a review from a team as a code owner August 14, 2023 12:39
@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Merging #2000 (13ff4ff) into segment-anding (b4b00cc) will not change coverage.
Report is 1 commits behind head on segment-anding.
The diff coverage is n/a.

@@               Coverage Diff               @@
##           segment-anding    #2000   +/-   ##
===============================================
  Coverage           70.97%   70.97%           
===============================================
  Files                  69       69           
  Lines                6743     6743           
===============================================
  Hits                 4786     4786           
  Misses               1684     1684           
  Partials              273      273           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@yquansah yquansah requested a review from markphelps August 14, 2023 14:37
Copy link
Member

@GeorgeMac GeorgeMac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@yquansah yquansah merged commit 0856141 into segment-anding Aug 14, 2023
@yquansah yquansah deleted the cue-validation branch August 14, 2023 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants