chore(rollouts): account for segments without constraints #1919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yquansah
commented
Jul 28, 2023
| Value: "bar", | ||
| }) | ||
|
|
||
| require.NoError(t, err) |
There was a problem hiding this comment.
Removed the CreateConstraint here to ensure that the query still picks up the necessary information.
Codecov Report
@@ Coverage Diff @@
## main #1919 +/- ##
==========================================
- Coverage 71.35% 71.26% -0.10%
==========================================
Files 66 66
Lines 6455 6455
==========================================
- Hits 4606 4600 -6
- Misses 1592 1596 +4
- Partials 257 259 +2 see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
markphelps
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add logic to account for segments without constraints. For rules, segments without constraints result in a match during evaluation. This PR does the following:
LEFT JOINinstead of aJOINin the query to get segments that do not have constraints out of the db