Remove extra dashes when auto generating key #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-key-extra-dashes
|
Not sure why the Lint check is just stuck... |
|
@aaronraff thanks this is great! And thank you for adding some JS tests! Greatly appreciated! Yeah idk whats going on with the Lint Check either.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #165
This adds logic to strip out extra hyphens that are added when auto generating flag and segment keys. It also pulls the common logic out into a mixin to reduce redundant code. This also modifies the logic to remove beginning and trailing hyphens.
I went ahead and added a few tests for the mixin as well. Eventually, I would like to take a look at adding some Vue tests that actually make assertions against the UI components data.