chore: make UI dev easier #1478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markphelps
commented
Apr 10, 2023
| @@ -1,13 +1,28 @@ | |||
| <!DOCTYPE html> | |||
There was a problem hiding this comment.
this is simply to get unit tests/etc to pass as our build expects this file to be here. it will get overwritten during the mage or mage dev tasks and is added to .gitignore so any changes will not be committed to git
Codecov Report
@@ Coverage Diff @@
## main #1478 +/- ##
=======================================
Coverage 77.77% 77.77%
=======================================
Files 44 44
Lines 3402 3402
=======================================
Hits 2646 2646
Misses 603 603
Partials 153 153 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes
index.htmlfor the UI to be a template that is rendered differently if we are building for 'release' mode or 'development' mode.If in development mode, it proxies all UI requests to the
npm devserver which allows for hot reloading via vite: https://vitejs.dev/guide/backend-integration.htmlAlso updates to include better instructions on what to do when running
mageormage dev