Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add frame-ancestors directive to CSP header #1317

Merged
merged 1 commit into from
Feb 6, 2023

Conversation

markphelps
Copy link
Collaborator

Fixes: FLI-190

Adds missing frame-ancestors directive to Content-Security-Policy response header to prevent clickjacking

https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Security-Policy/frame-ancestors

@markphelps markphelps requested a review from a team as a code owner February 4, 2023 19:52
@codecov-commenter
Copy link

codecov-commenter commented Feb 4, 2023

Codecov Report

Merging #1317 (2e7070b) into main (0af41e9) will increase coverage by 0.09%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #1317      +/-   ##
==========================================
+ Coverage   80.37%   80.46%   +0.09%     
==========================================
  Files          43       43              
  Lines        3307     3307              
==========================================
+ Hits         2658     2661       +3     
+ Misses        518      516       -2     
+ Partials      131      130       -1     
Impacted Files Coverage Δ
internal/server/flag.go 81.92% <100.00%> (+3.61%) ⬆️
internal/server/rule.go 76.92% <100.00%> (+3.84%) ⬆️
internal/server/segment.go 79.16% <100.00%> (+4.16%) ⬆️
internal/storage/oplock/sql/sql.go 90.82% <0.00%> (-5.51%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@GeorgeMac GeorgeMac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🔒

@markphelps markphelps merged commit 165ba79 into main Feb 6, 2023
@markphelps markphelps deleted the csp-frame-ancestors branch February 6, 2023 12:55
markphelps added a commit that referenced this pull request Feb 6, 2023
* main:
  chore: add frame-ancestors directive to CSP header (#1317)
  chore(deps): bump github.com/gofrs/uuid (#1319)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants