Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dont print to stdout using color/non json formatted output when running with JSON output logger #1188

Merged
merged 1 commit into from
Dec 1, 2022

Conversation

markphelps
Copy link
Collaborator

Fixes: #1186

@markphelps markphelps requested a review from a team as a code owner December 1, 2022 18:50
@codecov-commenter
Copy link

codecov-commenter commented Dec 1, 2022

Codecov Report

Merging #1188 (26a4af0) into main (6aaace6) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1188   +/-   ##
=======================================
  Coverage   79.87%   79.87%           
=======================================
  Files          38       38           
  Lines        2758     2758           
=======================================
  Hits         2203     2203           
  Misses        451      451           
  Partials      104      104           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@markphelps markphelps merged commit 79f86b2 into main Dec 1, 2022
@markphelps markphelps deleted the dont-print-non-json branch December 1, 2022 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FLI-99] Ensure only JSON output is sent to STDOUT/STDERR if json log format enabled
3 participants