fix(config/cors): use strings.Fields for string to string slice fields #1179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeorgeMac
added a commit
that referenced
this pull request
Nov 29, 2022
GeorgeMac
added a commit
that referenced
this pull request
Nov 29, 2022
Merged
GeorgeMac
added a commit
that referenced
this pull request
Nov 30, 2022
GeorgeMac
added a commit
that referenced
this pull request
Nov 30, 2022
* chore: update CHANGELOG for v1.16.0 * chore: update CHANGELOG with ref to #1179 Co-authored-by: Mark Phelps <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@showwin pointed out that we regressed in terms of splitting behaviour on
allowed_originshere:#1173
Before the config refactor, we were splitting using
strings.Fields()(this was the internal behaviour ofviper.GetStringSlice()). Afterwards,mapstructure.StringToSliceHook(",")was leading to a simplestrings.Split(..., ",").This adjusts the string to slice hook to use
strings.Fields(...).This function treats one or more consecutive whitespace characters as a delimiter.
I added an example case to demonstrate this.
Once merged, we will cut a few patch releases on previous versions.