Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(server): add metrics around flag evaluations #1150

Merged
merged 1 commit into from
Nov 22, 2022
Merged

feat(server): add metrics around flag evaluations #1150

merged 1 commit into from
Nov 22, 2022

Conversation

GeorgeMac
Copy link
Member

@GeorgeMac GeorgeMac commented Nov 21, 2022 •
edited
Loading

Fixes FLI-86

This adds metrics around flag evaluations. Specifically:

  • Total evaluations
  • Total errors
  • Results including match, reason, segment and value.
  • Latency

Each keyed by flag. The following is an example dashboard:
Screenshot 2022-11-21 at 17 03 06

@GeorgeMac GeorgeMac requested a review from a team as a code owner November 21, 2022 17:05
markphelps
markphelps approved these changes Nov 21, 2022
View reviewed changes
Copy link
Collaborator

@markphelps markphelps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@GeorgeMac GeorgeMac merged commit 369e4fc into main Nov 22, 2022
@GeorgeMac GeorgeMac deleted the gm/evaluation-metrics branch November 22, 2022 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markphelps markphelps markphelps approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GeorgeMac @markphelps