Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CockroachDB Support #1064

Merged
merged 9 commits into from
Oct 14, 2022
Merged

CockroachDB Support #1064

merged 9 commits into from
Oct 14, 2022

Conversation

markphelps
Copy link
Collaborator

@markphelps markphelps commented Oct 10, 2022 •
edited
Loading

Fixes: #975
Fixes: FLI-18

Adds (Beta) support for cockroachdb

cc @z0mb1ek

@markphelps markphelps requested a review from GeorgeMac October 10, 2022 20:19
@codecov-commenter
Copy link

codecov-commenter commented Oct 10, 2022 •
edited
Loading

Codecov Report

Merging #1064 (531df7b) into main (976d19e) will decrease coverage by 0.13%.
The diff coverage is 66.66%.

❗ Current head 531df7b differs from pull request most recent head 6df2bd2. Consider uploading reports for the commit 6df2bd2 to get more accurate results

@@            Coverage Diff             @@
##             main    #1064      +/-   ##
==========================================
- Coverage   80.83%   80.69%   -0.14%     
==========================================
  Files          17       17              
  Lines        1915     1922       +7     
==========================================
+ Hits         1548     1551       +3     
- Misses        283      287       +4     
  Partials       84       84
Impacted Files Coverage Δ
internal/config/config.go 89.25% <ø> (ø)
internal/storage/sql/migrator.go 27.14% <0.00%> (-1.65%) ⬇️
internal/storage/sql/db.go 94.78% <100.00%> (+0.13%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@markphelps markphelps marked this pull request as ready for review October 10, 2022 20:37
@markphelps markphelps requested a review from tsickert October 11, 2022 01:10
@markphelps markphelps changed the title Cockroach CockroachDB Support Oct 11, 2022
GeorgeMac
GeorgeMac approved these changes Oct 14, 2022
View reviewed changes
Copy link
Contributor

@GeorgeMac GeorgeMac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks solid.

I pulled it down and run the docker compose setup. Works a dream.
Needs rebuilding of flipt/flipt:latest beforehand if anyone else is going to try from this PR.

@markphelps markphelps merged commit 9f8127f into main Oct 14, 2022
@markphelps markphelps deleted the cockroach branch October 14, 2022 15:24
markphelps added a commit that referenced this pull request Oct 17, 2022
@markphelps
Merge branch 'main' into release/1.13
71d6555 
* main:
  Bump google.golang.org/grpc from 1.50.0 to 1.50.1 (#1074)
  CockroachDB Support (#1064)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeorgeMac GeorgeMac GeorgeMac approved these changes

@tsickert tsickert Awaiting requested review from tsickert

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support CockroachDB
3 participants
@markphelps @codecov-commenter @GeorgeMac