fix: initialize shutdown context timeout after interrupt #1057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeorgeMac
force-pushed
the
gm/shutdown-context
branch
from
1d56fdd to
0556496
Compare
|
Good find @GeorgeMac ! I added one change, previously we were only logging when the HTTP server shutdown, I added logging for the GRPC server as well: Before^C2022-10-05T09:26:33-04:00 INFO shutting down...
2022-10-05T09:26:33-04:00 INFO server shutdown gracefully {"server": "http"}After^C2022-10-05T09:22:55-04:00 INFO shutting down...
2022-10-05T09:22:55-04:00 INFO grpc server shutdown gracefully {"server": "grpc"}
2022-10-05T09:22:55-04:00 INFO http server shutdown gracefully {"server": "http"} |
Codecov Report
@@ Coverage Diff @@
## main #1057 +/- ##
=======================================
Coverage 81.40% 81.40%
=======================================
Files 17 17
Lines 1828 1828
=======================================
Hits 1488 1488
Misses 265 265
Partials 75 75 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
markphelps
added a commit
that referenced
this pull request
Oct 5, 2022
…nto list-pagination * 'list-pagination' of https://github.com/flipt-io/flipt: fix: initialize shutdown context timeout after interrupt (#1057)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a quick fix for an observation.
The shutdown context and 5 second timeout was getting initialized on Flipt start.
Meaning, the shutdown context was likely (unless Flipt was stopped immediately) to be well and truly cancelled before any interrupt is sent.
This moves the initialization of the 5-second timeout context to be after any interrupt is received.
Ensuring at-least five seconds grace period is given on shutdown (maybe this should be configurable too at some point).