-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: replace opentracing with opentelemetry #1053
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1053 +/- ##
==========================================
+ Coverage 81.33% 81.40% +0.06%
==========================================
Files 17 17
Lines 1822 1828 +6
==========================================
+ Hits 1482 1488 +6
Misses 265 265
Partials 75 75
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
markphelps
reviewed
Oct 4, 2022
🎉 amazing! ty checking this out now! |
markphelps
approved these changes
Oct 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks again @GeorgeMac !!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #576
This is an attempt to replace the open-tracing libraries with the open-telemetry alternatives.
The PR does not attempt to change any of the current Flipt configuration for tracing.
Instead, it demonstrates how we can move to the
otel
abstractions for tracing, without touching existing configuration.I propose we explore furthering the configurations options in a subsequent PR.
(e.g. support for more exporters and so on).
The most significant change is the slight deviation in the span and trace contents for SQL.
Though, there are some subtle differences in the gRPC ones as well.
See the following images for an illustration:
OpenTracing:
OpenTelemetry:
args
astags
.I would argue this is preferable. There is no need to index all these traces by the arguments presented to each query.
Might be favourable down the line to introduce SQL arguments as span log statements.
.
over-
as delimiter when producing span names.query
tag becomesdb.statement
.To get SQL support, I have added the https://github.com/XSAM/otelsql library.
As this was advised in an
otel
related issue as the best supported implementation for now.Take it or leave it: I added a Multistage build alternative Dockerfile.
This was just useful for debugging with docker compose.
Since I could get an equivalent alpine image built with it a little easier.