-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JSON log output #1027
JSON log output #1027
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1027 +/- ##
==========================================
- Coverage 81.26% 81.21% -0.05%
==========================================
Files 17 17
Lines 1799 1805 +6
==========================================
+ Hits 1462 1466 +4
- Misses 263 265 +2
Partials 74 74
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@markphelps nice. Yeah, might be worth dropping the banner when the encoding is JSON. As you say, the JSON encoder is likely to imply the output of the logging here is machine-readable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Couple take it or leave it suggestions.
Co-authored-by: George <[email protected]>
Co-authored-by: George <[email protected]>
Fixes #992
FLIPT_LOG_ENCODING
env var or settinglog.encoding
via yaml/cc @GeorgeMac
TODO