This repository has been archived by the owner on Apr 10, 2023. It is now read-only.
fix(fetch): pass credentials: include #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markphelps
reviewed
Jan 17, 2023
| @@ -234,6 +234,6 @@ export async function evaluate(flagKey: string, values: any) { | |||
| // | |||
| // meta | |||
| export async function getInfo() { | |||
| const res = await fetch(`${metaURL}/info`); | |||
| const res = await fetch(metaURL + '/info', { credentials: 'include' }); | |||
There was a problem hiding this comment.
@GeorgeMac I'm guessing we'll need to add this to all our API calls?
markphelps
approved these changes
Jan 17, 2023
markphelps
added a commit
that referenced
this pull request
Jan 18, 2023
* main: fix(fetch): pass credentials: include (#6) chore: rename error hook; cleanup (#31) chore(deps-dev): bump prettier from 2.8.2 to 2.8.3 (#29) chore(deps-dev): bump @typescript-eslint/eslint-plugin (#34) chore(deps-dev): bump @typescript-eslint/parser from 5.48.1 to 5.48.2 (#35) chore(deps-dev): bump eslint from 8.31.0 to 8.32.0 (#30) chore(deps-dev): bump eslint-plugin-react from 7.32.0 to 7.32.1 (#33) chore(deps-dev): bump eslint-plugin-import from 2.27.4 to 2.27.5 (#32)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is perhaps a little premature. However, I have auth running locally and bumped into a bit.
Ultimately, we're going to want this enabled on requests. For Cookies to be sent.
I also updated the fetcher a little to include more details. Stolen from the SWR docs themselves:
https://swr.vercel.app/docs/error-handling#status-code-and-error-object