Added visual cueing when submitting forms

src/app/Layout.tsx

@@ -1,10 +1,11 @@
 import { useState } from 'react';
 import { Navigate, Outlet } from 'react-router-dom';
+import SuccessNotification from '~/components/SuccessNotification';
 import { useSession } from '~/data/hooks/session';
 import ErrorNotification from '../components/ErrorNotification';
-import { ErrorProvider } from '../components/ErrorProvider';
 import Footer from '../components/Footer';
 import Header from '../components/Header';
+import { NotificationProvider } from '../components/NotificationProvider';
 import Sidebar from '../components/Sidebar';
 
 function InnerLayout() {
@@ -34,9 +35,10 @@ function InnerLayout() {
 
 export default function Layout() {
   return (
-    <ErrorProvider>
+    <NotificationProvider>
       <InnerLayout />
       <ErrorNotification />
-    </ErrorProvider>
+      <SuccessNotification />
+    </NotificationProvider>
   );
 }

src/components/Loading.tsx

@@ -1,7 +1,22 @@
-export default function Loading() {
+type LoadingProps = {
+  isButton?: boolean;
+  isPrimary?: boolean;
+};
+
+export default function Loading(props: LoadingProps) {
+  const { isButton, isPrimary } = props;
+
   return (
-    <div className="flex h-screen items-center justify-center">
-      <div className="h-10 w-10 animate-spin rounded-full border-b-2 border-violet-300"></div>
+    <div
+      className={`flex ${
+        !isButton ? 'h-screen' : ''
+      } items-center justify-center`}
+    >
+      <div
+        className={`${isButton ? 'h-5 w-5' : 'h-10 w-10'} ${
+          isPrimary ? 'border-white-300' : 'border-violet-300'
+        } animate-spin rounded-full border-b-2`}
+      ></div>
     </div>
   );
 }

src/components/NotificationProvider.tsx

@@ -0,0 +1,48 @@
+import { createContext, useState } from 'react';
+
+type ErrorContext = {
+  error: Error | null;
+  setError(_error: Error | null): void;
+  clearError(): void;
+};
+
+type SuccessContext = {
+  success: string | null;
+  setSuccess(_success: string | null): void;
+  clearSuccess(): void;
+};
+
+export const NotificationContext = createContext<ErrorContext & SuccessContext>(
+  {
+    error: null as Error | null,
+    setError(_error: Error | null) {},
+    clearError() {},
+    success: null as string | null,
+    setSuccess(_success: string | null) {},
+    clearSuccess() {}
+  }
+);
+
+export function NotificationProvider({
+  children
+}: {
+  children: React.ReactNode;
+}) {
+  const [error, setError] = useState<Error | null>(null);
+  const [success, setSuccess] = useState<string | null>(null);
+
+  return (
+    <NotificationContext.Provider
+      value={{
+        error,
+        setError,
+        clearError: () => setError(null),
+        success,
+        setSuccess,
+        clearSuccess: () => setSuccess(null)
+      }}
+    >
+      {children}
+    </NotificationContext.Provider>
+  );
+}

src/components/SuccessNotification.tsx

@@ -0,0 +1,39 @@
+import { Transition } from '@headlessui/react';
+import { CheckCircleIcon, XMarkIcon } from '@heroicons/react/20/solid';
+import { useSuccess } from '~/data/hooks/success';
+
+export default function SuccessNotification() {
+  const { success, setSuccess } = useSuccess();
+
+  return (
+    <Transition show={success !== null}>
+      <div className="max-w-s fixed bottom-0 right-2 z-10 m-4">
+        <div className="rounded-md bg-green-50 p-4">
+          <div className="flex">
+            <div className="flex-shrink-0">
+              <CheckCircleIcon
+                className="h-5 w-5 text-green-400"
+                aria-hidden="true"
+              />
+            </div>
+            <div className="ml-3">
+              <p className="text-sm font-medium text-green-800">{success}</p>
+            </div>
+            <div className="ml-auto pl-3">
+              <div className="-mx-1.5 -my-1.5">
+                <button
+                  type="button"
+                  onClick={() => setSuccess(null)}
+                  className="inline-flex rounded-md bg-green-50 p-1.5 text-green-500 hover:bg-green-100 focus:outline-none focus:ring-2 focus:ring-green-600 focus:ring-offset-2 focus:ring-offset-green-50"
+                >
+                  <span className="sr-only">Dismiss</span>
+                  <XMarkIcon className="h-5 w-5" aria-hidden="true" />
+                </button>
+              </div>
+            </div>
+          </div>
+        </div>
+      </div>
+    </Transition>
+  );
+}

src/components/flags/FlagForm.tsx

@@ -6,9 +6,11 @@ import Input from '~/components/forms/Input';
 import Toggle from '~/components/forms/Toggle';
 import { createFlag, updateFlag } from '~/data/api';
 import { useError } from '~/data/hooks/error';
+import { useSuccess } from '~/data/hooks/success';
 import { keyValidation, requiredValidation } from '~/data/validations';
 import { IFlag, IFlagBase } from '~/types/Flag';
 import { stringAsKey } from '~/utils/helpers';
+import Loading from '../Loading';
 
 type FlagFormProps = {
   flag?: IFlag;
@@ -18,8 +20,10 @@ type FlagFormProps = {
 export default function FlagForm(props: FlagFormProps) {
   const { flag, flagChanged } = props;
   const isNew = flag === undefined;
+  const submitPhrase = isNew ? 'Create' : 'Update';
   const navigate = useNavigate();
   const { setError, clearError } = useError();
+  const { setSuccess } = useSuccess();
 
   const handleSubmit = (values: IFlagBase) => {
     if (isNew) {
@@ -43,7 +47,9 @@ export default function FlagForm(props: FlagFormProps) {
         handleSubmit(values)
           .then(() => {
             clearError();
-
+            setSuccess(
+              `Successfully ${submitPhrase.toLocaleLowerCase()}d flag`
+            );
             if (isNew) {
               navigate(`/flags/${values.key}`);
               return;
@@ -52,6 +58,7 @@ export default function FlagForm(props: FlagFormProps) {
             flagChanged && flagChanged();
           })
           .catch((err) => {
+            console.log(err);
             setError(err);
           });
       }}
@@ -147,11 +154,17 @@ export default function FlagForm(props: FlagFormProps) {
                 </Button>
                 <Button
                   primary
-                  className="ml-3"
+                  className="ml-3 min-w-[80px]"
                   type="submit"
-                  disabled={!(formik.dirty && formik.isValid)}
+                  disabled={
+                    !(formik.dirty && formik.isValid && !formik.isSubmitting)
+                  }
                 >
-                  {isNew ? 'Create' : 'Update'}
+                  {formik.isSubmitting ? (
+                    <Loading isButton isPrimary />
+                  ) : (
+                    submitPhrase
+                  )}
                 </Button>
               </div>
             </div>

src/components/flags/VariantForm.tsx

@@ -8,8 +8,10 @@ import TextArea from '~/components/forms/TextArea';
 import MoreInfo from '~/components/MoreInfo';
 import { createVariant, updateVariant } from '~/data/api';
 import { useError } from '~/data/hooks/error';
+import { useSuccess } from '~/data/hooks/success';
 import { jsonValidation, keyValidation } from '~/data/validations';
 import { IVariant, IVariantBase } from '~/types/Variant';
+import Loading from '../Loading';
 
 type VariantFormProps = {
   setOpen: (open: boolean) => void;
@@ -22,7 +24,9 @@ export default function VariantForm(props: VariantFormProps) {
   const { setOpen, flagKey, variant, onSuccess } = props;
   const isNew = variant === undefined;
   const title = isNew ? 'New Variant' : 'Edit Variant';
+  const submitPhrase = isNew ? 'Create' : 'Update';
   const { setError, clearError } = useError();
+  const { setSuccess } = useSuccess();
 
   const handleSubmit = async (values: IVariantBase) => {
     if (isNew) {
@@ -44,6 +48,9 @@ export default function VariantForm(props: VariantFormProps) {
         handleSubmit(values)
           .then(() => {
             clearError();
+            setSuccess(
+              `Successfully ${submitPhrase.toLocaleLowerCase()}d variant.`
+            );
             onSuccess();
           })
           .catch((err) => {
@@ -155,10 +162,17 @@ export default function VariantForm(props: VariantFormProps) {
               <Button onClick={() => setOpen(false)}>Cancel</Button>
               <Button
                 primary
+                className="min-w-[80px]"
                 type="submit"
-                disabled={!(formik.dirty && formik.isValid)}
+                disabled={
+                  !(formik.dirty && formik.isValid && !formik.isSubmitting)
+                }
               >
-                {isNew ? 'Create' : 'Update'}
+                {formik.isSubmitting ? (
+                  <Loading isButton isPrimary />
+                ) : (
+                  submitPhrase
+                )}
               </Button>
             </div>
           </div>