Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add gcp docs #168

Merged
merged 3 commits into from
Jan 10, 2024
Merged

feat: add gcp docs #168

merged 3 commits into from
Jan 10, 2024

Conversation

markphelps
Copy link
Contributor

@markphelps markphelps requested a review from erka January 9, 2024 21:31
@markphelps markphelps requested a review from a team as a code owner January 9, 2024 21:31
erka
erka approved these changes Jan 10, 2024
View reviewed changes
Copy link
Collaborator

@erka erka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

One minor thing is that prefix also could be used.

@markphelps @erka
chore: Update storage.mdx
65150c3 
Co-authored-by: Roman Dmytrenko <[email protected]>
@markphelps markphelps enabled auto-merge (squash) January 10, 2024 12:34
@markphelps markphelps merged commit 9eeee44 into main Jan 10, 2024
4 checks passed
@markphelps markphelps deleted the gcp-docs branch January 10, 2024 12:34
markphelps added a commit that referenced this pull request Jan 10, 2024
@markphelps
Merge branch 'main' into jwt-docs
cfc7b48 
* main:
  chore: add new grpc conn settings (#169)
  feat: add gcp docs (#168)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erka erka erka approved these changes

@GeorgeMac GeorgeMac GeorgeMac approved these changes

@yquansah yquansah yquansah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@markphelps @erka @GeorgeMac @yquansah