Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stack 1.9.3 to v2 image #3

Merged
merged 2 commits into from
Dec 20, 2018
Merged

Add stack 1.9.3 to v2 image #3

merged 2 commits into from
Dec 20, 2018

Conversation

onslaughtq
Copy link
Member

A version of the v2 image with stack 1.9.3 has been added,
and the README has been updated to reflect this as well.

A version of the v2 image with stack 1.9.3 has been added,
and the README has been updated to reflect this as well.
v2/1.9.3/Dockerfile Outdated Show resolved Hide resolved
@qxjit
Copy link
Member

qxjit commented Dec 20, 2018

@onslaughtq Can you try the workaround suggested in the linked items (adding --batch) and see if it will build? I'd like to record the problem and fix as part of this PR, but I can't push to your fork to make it appear here.

Due to a side-effect of a bug-fix in the gpg command, it is now
necessary to pass --batch to gpg commands that you wouldn't expect
to allocate a /dev/tty device.

In general though, passing --batch to gpg commands run within a script
is probably a good practice to follow.
@onslaughtq
Copy link
Member Author

Passing --batch to the gpg command has now resolved this issue and the image can be built again

Copy link
Member

@qxjit qxjit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to build an image and the orville tests are passing on all lts versions that orville currently builds with. I'll push the image to docker hub and merge this.

@qxjit qxjit merged commit c661a89 into flipstone:master Dec 20, 2018
@onslaughtq onslaughtq deleted the v2-1.9.3 branch February 1, 2019 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants