[sc-39654] Add ghciwatch #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
telser
reviewed
Oct 30, 2024
Dockerfile
Outdated
| RUN /bin/sh /install-tools.sh | ||
|
|
||
| ADD install-tools.sh /install-tools.sh | ||
| RUN bash /install-tools.sh |
There was a problem hiding this comment.
Please don't use bash. We don't need it for the tests in the install-tools.sh anyway
telser
reviewed
Oct 30, 2024
install-tools.sh
Outdated
| @@ -1,5 +1,16 @@ | |||
| set -o errexit | |||
|
|
|||
| arch=$(uname -m) | |||
| if [[ $arch == x86_64 ]]; then | |||
There was a problem hiding this comment.
We should be able to do this with a normal call to test in bourne shell. ShellCheck is a big help for this kind of thing.
telser
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested locally. I moved down the
ADDsuch that it becomes easier to debug. When the ADD is at the top, you have to reinstall GHC and HLS every time you make a change toinstall-tools.sh.