Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add additional keys to elite dict #89

Merged
merged 3 commits into from
Dec 20, 2023

Conversation

kitsunehunter
Copy link
Contributor

@kitsunehunter kitsunehunter commented Dec 19, 2023

What's new

  • From the last few issues regarding reading elite iCLASS legacy credentials on discord, a lot of them has been resolved by having the user add additional keys to their user dictionary. Having the keys by default in the elite dictionary should allow more cards be read with the picopass app without having the user import more keys

Verification

  • key a iclass legacy credential (with a working PACS payload) to any of the keys in the long list of 700+ keys.
  • use flipper to write a iclass legacy PACS payload to a legacy credential and then change the key from flipper interface
  • elite dict attack and picopass read should both read the credential after a short time
  • Note: simulated elite credentials on pm3 will not work for testing due to no MAC verification. Flipper zero with #define PICOPASS_DEBUG_IGNORE_BAD_RMAC disabled (function undefined) should emulate elite correctly for testing purposes.
  • elite keyed .picopass files included for emulating with a second flipper

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@kitsunehunter
Copy link
Contributor Author

Elite.picopass.json
Elite2.picopass.json

remove the .json to use the picopass elite keyed test file

bettse
bettse previously approved these changes Dec 19, 2023
Copy link
Collaborator

@bettse bettse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't love that the regular read will also check all of these and doesn't have the progress bar, but that can be a future improvement

@skotopes skotopes merged commit aa05d75 into flipperdevices:dev Dec 20, 2023
2 checks passed
@kitsunehunter kitsunehunter deleted the update_elite_dictionary branch December 20, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants