Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify in error scene that only Gen1 magic and Gen4 UMCs are supported #75

Merged
merged 3 commits into from
Dec 6, 2023
Merged

Specify in error scene that only Gen1 magic and Gen4 UMCs are supported #75

merged 3 commits into from
Dec 6, 2023

Conversation

kitsunehunter
Copy link
Contributor

@kitsunehunter kitsunehunter commented Nov 23, 2023 •
edited by skotopes
Loading

What's new

  • As a end user, I would like to know what specific magic cards are supported when a unsupported credential is scanned by the "check magic tag" option. Instead of just a generic error of "Not magic or unsupported card," the error page will tell the user that the only supported magic cards are Gen1 and Gen4 UMC. Should help reduce confusion between Gen4 UMC (GTU) and Gen4 GDM (USCUID / GDMIC) which is not currently supoorted.

Verification

  • Launch NFC Magic app and scan a unsupported credential. The error page should clearly tell the user that only Gen1 and Gen4 UMC cards are supported with no text overlap / cutoff / word wrap.
  • No additional regression testing is necessary.

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@hedger hedger added enhancement New feature or request app:nfc_magic labels Nov 25, 2023
@skotopes skotopes merged commit db08fca into flipperdevices:dev Dec 6, 2023
2 checks passed
@kitsunehunter kitsunehunter deleted the specific_magic_cards branch December 7, 2023 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skotopes skotopes skotopes approved these changes

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@hedger hedger Awaiting requested review from hedger hedger is a code owner

@gornekich gornekich Awaiting requested review from gornekich gornekich is a code owner

Assignees
No one assigned
Labels
app:nfc_magic enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kitsunehunter @skotopes @hedger