-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FL-3593] Picopass rework. Part 1 #68
Conversation
Hello @bettse, @nvx ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked over the code (not so much the emulation, since that I'm not as familiar with) and did some tests against cards I have and it looks good to me. (I'd wait until the other guys get a chance to weigh in before merging though)
@nvx should we wait for you? because firmware is going to be release soon |
I haven't had a heap of time to look over everything, but of what I have seen so far nothing stands out as an issue so happy to send it for now. I'm sure once users have it there will be edge cases identified that need fixing though, but that's probably the case for the entire NFC refactor. |
There seems to be a bug (or a feature?) where if you Read an iClass DP or iClass GP then use "Change Key" > "Write Elite" >Save (without editing anything), it will write to the card but then it will completly render the DP and GP cards unreadable and unwritable (bricking the card?). |
open a separate issue about this and include more details like what the state of the card was |
And include whether or not the key you set the card to is in your user dictionary |
What's new
Verification
Checklist (For Reviewer)