Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FL-3593] Picopass rework. Part 1 #68

Merged
merged 4 commits into from
Oct 31, 2023
Merged

Conversation

gornekich
Copy link
Member

@gornekich gornekich commented Oct 28, 2023

What's new

  • Introduce picopass poller and listener
  • Rework reading, writing, emulating, loclass attack with new NFC API

Verification

  • Test Picopass application. Verify it works as before

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@gornekich
Copy link
Member Author

Hello @bettse, @nvx !
As we agreed, I opened another PR with refactored "worker" part. It is still pretty big, but I think it is much easier for review. I removed old picopass_worker files, introduced picopass_poller and picopass_listener instead. I tried to make as little changes as possible in application part.
Please, let me know if you have any questions.

bettse
bettse previously approved these changes Oct 29, 2023
Copy link
Collaborator

@bettse bettse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked over the code (not so much the emulation, since that I'm not as familiar with) and did some tests against cards I have and it looks good to me. (I'd wait until the other guys get a chance to weigh in before merging though)

@skotopes
Copy link
Member

@nvx should we wait for you? because firmware is going to be release soon

@nvx
Copy link
Contributor

nvx commented Oct 31, 2023

@nvx should we wait for you? because firmware is going to be release soon

I haven't had a heap of time to look over everything, but of what I have seen so far nothing stands out as an issue so happy to send it for now. I'm sure once users have it there will be edge cases identified that need fixing though, but that's probably the case for the entire NFC refactor.

@skotopes skotopes merged commit 8f9c0ee into dev Oct 31, 2023
2 checks passed
@skotopes skotopes deleted the gornek/3593_picopass_rework_part1 branch October 31, 2023 11:23
@glennlopez
Copy link

glennlopez commented Jan 31, 2024

There seems to be a bug (or a feature?) where if you Read an iClass DP or iClass GP then use "Change Key" > "Write Elite" >Save (without editing anything), it will write to the card but then it will completly render the DP and GP cards unreadable and unwritable (bricking the card?).

@nvx
Copy link
Contributor

nvx commented Jan 31, 2024

There seems to be a bug (or a feature?) where if you Read an iClass DP or iClass GP then use "Change Key" > "Write Elite" >Save (without editing anything), it will write to the card but then it will completly render the DP and GP cards unreadable and unwritable (bricking the card?).

open a separate issue about this and include more details like what the state of the card was

@bettse
Copy link
Collaborator

bettse commented Jan 31, 2024

And include whether or not the key you set the card to is in your user dictionary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants