Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Picopass: rename RFAL_PICOPASS_BLOCK_LEN #63

Merged
merged 3 commits into from
Oct 24, 2023
Merged

Picopass: rename RFAL_PICOPASS_BLOCK_LEN #63

merged 3 commits into from
Oct 24, 2023

Conversation

bettse
Copy link
Collaborator

@bettse bettse commented Oct 24, 2023 •
edited by hedger
Loading

What's new

Verification

  • run ufbt and see it build successfully

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@bettse bettse mentioned this pull request Oct 24, 2023
Closed
3 tasks
@bettse bettse marked this pull request as ready for review October 24, 2023 00:25
@bettse
Copy link
Collaborator Author

bettse commented Oct 24, 2023

Based on the build failure, I assume ufbt isn't running in release, but rc or dev mode?

@gornekich
Copy link
Member

Based on the build failure, I assume ufbt isn't running in release, but rc or dev mode?

Yes, ufbt takes SDK from RC. We will merge it anyway, thanks!

@hedger hedger merged commit 73bc6e4 into flipperdevices:dev Oct 24, 2023
0 of 2 checks passed
@bettse bettse deleted the picopass_rename_constant branch October 24, 2023 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gornekich gornekich gornekich approved these changes

@skotopes skotopes Awaiting requested review from skotopes skotopes is a code owner

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@hedger hedger Awaiting requested review from hedger hedger is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bettse @gornekich @hedger