Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Picopass: populate key change input with first key of user dictionary #54

Merged
merged 1 commit into from
Sep 27, 2023
Merged

Picopass: populate key change input with first key of user dictionary #54

merged 1 commit into from
Sep 27, 2023

Conversation

bettse
Copy link
Collaborator

@bettse bettse commented Sep 25, 2023 •
edited by skotopes
Loading

What's new

  • To make changing keys easier, populate the manual key entry with the first key of the user's dictionary

Screenshot-20230924-193306

Verification

  • Upload a file to picopass/assets/iclass_elite_dict_user.txt
  • Read a card
  • Select More
  • Select Change Key
  • Select Write Elite
  • See the first key of the user dictionary populated in input box

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@bettse bettse marked this pull request as ready for review September 25, 2023 03:06
@pcunning
Copy link

This worked very nicely

@skotopes skotopes merged commit 7e7df47 into flipperdevices:dev Sep 27, 2023
@bettse bettse deleted the picopass_populate_key_change branch September 27, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skotopes skotopes skotopes approved these changes

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@hedger hedger Awaiting requested review from hedger hedger is a code owner

@gornekich gornekich Awaiting requested review from gornekich gornekich is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bettse @pcunning @skotopes