Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Picopass: Add haptics to loclass #53

Merged
merged 2 commits into from
Sep 27, 2023
Merged

Picopass: Add haptics to loclass #53

merged 2 commits into from
Sep 27, 2023

Conversation

bettse
Copy link
Collaborator

@bettse bettse commented Sep 25, 2023 •
edited by skotopes
Loading

What's new

  • Added haptics to picopass

Verification

  • Run loclass
  • Place against reader with standard key
  • Experience "error" haptic
  • Place against reader with elite key
  • Experience single vibration for each response (they can feel almost like one long (~half second) vibration. Experience quick pause and final vibration (in reality a double vibration) when all 18 are collected.

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@bettse
Copy link
Collaborator Author

bettse commented Sep 25, 2023

@nvx Let me know if you have a chance to try this and what you think, given much of loclass has been under your leadership.

@pcunning
Copy link

tested and works as expected, could update the success message to also do the beep when the sound is on

@nvx
Copy link
Contributor

nvx commented Sep 26, 2023

Looks good!

@bettse bettse marked this pull request as ready for review September 26, 2023 22:30
@skotopes skotopes merged commit 6d61acd into flipperdevices:dev Sep 27, 2023
@bettse bettse deleted the picopass_loclass_haptics branch September 27, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skotopes skotopes skotopes approved these changes

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@hedger hedger Awaiting requested review from hedger hedger is a code owner

@gornekich gornekich Awaiting requested review from gornekich gornekich is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bettse @pcunning @nvx @skotopes