-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve loclass logic for readers doing keyrolling. #50
Improve loclass logic for readers doing keyrolling. #50
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't claim to know all the details of loclass, but overall the codes makes sense.
I used the nfc-iclass project to make a "KDE" keyroll config card, which I used on a Rev A reader. I ran the new code against it, downloaded the file, and was able to use https://loclass.ericbetts.dev/ to calculate the key I'd configured 😁. |
Writing to the loclass log is now deferred until the CSN changes for speed.
7e09c15
to
98ab7f2
Compare
Fixed that bug with the numbering in the loclass log being wrong and also made the code a little more defensive in the emulation loop to stop when finished rather than relying on the UI to stop the emulation. |
Pulled down the new code and used it again with my keyrolled reader. So fast! Log looks good and works with loclass.ericbetts.dev. I'm going to use my new found poweres to approve try the "Approve and run" in the PR. |
Looks like I can approve, but merging is blocked 👍 |
@bettse looks like you are missing in codeowners. Can you make PR with it? |
Also don't forget changelog + catalog update |
We've also got #47 open, so we could do the bump after that |
okok |
Improve loclass logic for readers doing keyrolling. Writing to the loclass log is also now deferred until the CSN changes for speed.
What's new
Removes the forced anticoll between MAC collections except for when the CSN changes. This speeds up the collection process and should be more reliable with readers doing keyrolling.
Verification
Checklist (For Reviewer)