Picopass save written key

[bettse]

What's new

• When there is no user dictionary and the key of a card is changed to something the user input, save that value to a newly created user dictionary. We believe we've seen people get into a bad state (key all 0's) when they don't know what they're doing.

Verification

• Backup/delete user dictionary
• Read a standard keyed iClass
• Write key (defaults to all 0's)
• See user dictionary with all 0's key was created
• Try to read card again, see it was successful using all 0's key from user dictionary.

Checklist (For Reviewer)

• PR has description of feature/bug or link to Confluence/Jira task
• Description contains actions to verify feature/bugfix
• I've built this code, uploaded it to the device and verified feature/bugfix

[skotopes]

#0  0x080113a2 in __furi_crash_implementation () at furi/core/check.c:163
#1  0x08006636 in MemManage_Handler () at targets/f7/furi_hal/furi_hal_interrupt.c:283
#2  <signal handler called>
#3  iclass_elite_dict_add_key (dict=dict@entry=0x0, key=key@entry=0x2000a900 "") at /Users/aku/Work/Flipper/flipperzero-good-faps/picopass/helpers/iclass_elite_dict.c:157
#4  0x200108aa in picopass_scene_write_key_on_enter (context=0x2000a818) at /Users/aku/Work/Flipper/flipperzero-good-faps/picopass/scenes/picopass_scene_write_key.c:53
#5  0x2000f2d6 in picopass_scene_key_input_on_event (context=<optimized out>, event=...) at /Users/aku/Work/Flipper/flipperzero-good-faps/picopass/scenes/picopass_scene_key_input.c:35
#6  0x0806c848 in view_dispatcher_run (view_dispatcher=0x2000a290) at applications/services/gui/view_dispatcher.c:93
#7  0x200114bc in picopass_app (p=<optimized out>) at /Users/aku/Work/Flipper/flipperzero-good-faps/picopass/picopass.c:244
#8  0x0804be5c in flipper_application_thread (context=0x2000a460) at lib/flipper_application/flipper_application.c:224
#9  0x08013a74 in furi_thread_body (context=0x2000a740) at furi/core/thread.c:91
#10 0x08013a32 in furi_thread_catch () at furi/core/thread.c:62

Still crashing.

[skotopes]

/ext/apps_data/picopass folder is empty

[bettse]

I deleted the picopass folder and was able to reproduce. I thought subfolders were handled automatically, but not a big deal to add them. This should be good now, and I'll try to remember to test with no picopass for future stuff 👍

[bettse]

This is ready again and I think I fixed the crash

[skotopes]

Sorry for delay, I'm on vacation now and a little bit out of sync.

Key is not added to the dictionary.
Steps to reproduce:

• With dictionary exists on the sd card
• Write standard
• Write elite with custom key that is not in the dictionary
• Try to read, it fail
• Download dictionary and check that new key is not present

[bettse]

Ahh! Have a good vacation: this can wait!

With dictionary exists on the sd card

I assume you mean user dictionary, then this is expected. This PR is only to cover the case when the user does not have a user dictionary: we’ve had some users who don’t know what they’re doing set the key to all zeros. If a user has a user dictionary then, for now, we assume they know what they are doing.

[skotopes]

make sense, merged