Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

picopass: apply card to back view #118

Merged
merged 3 commits into from
Feb 6, 2024
Merged

picopass: apply card to back view #118

merged 3 commits into from
Feb 6, 2024

Conversation

bettse
Copy link
Collaborator

@bettse bettse commented Jan 27, 2024 •
edited by skotopes
Loading

What's new

  • Message if card isn't present

#109 (comment)
Screenshot-20240123-193225

Verification

  • Launch picopass->read without a card, see message
  • Present card, see dictionary attack

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@bettse bettse marked this pull request as ready for review January 29, 2024 04:43
@skotopes
Copy link
Member

Not sure if skip button is needed on read start screen:
image

Also after first successful read, reading again will show different message:
image

@bettse
Copy link
Collaborator Author

bettse commented Jan 31, 2024

Good catch! Fixed 👍

@bettse
Copy link
Collaborator Author

bettse commented Feb 2, 2024

this is ready for review again

@skotopes skotopes merged commit f82c44b into flipperdevices:dev Feb 6, 2024
2 checks passed
@bettse bettse deleted the picopass_read_ui_improvements branch February 7, 2024 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skotopes skotopes skotopes approved these changes

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@hedger hedger Awaiting requested review from hedger hedger is a code owner

@gornekich gornekich Awaiting requested review from gornekich gornekich is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bettse @skotopes