Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FL-1891] Release 0.42 bugfixes #891

Merged
merged 7 commits into from
Dec 12, 2021
Merged

[FL-1891] Release 0.42 bugfixes #891

merged 7 commits into from
Dec 12, 2021

Conversation

DrZlo13
Copy link
Member

@DrZlo13 DrZlo13 commented Dec 10, 2021 •
edited
Loading

What's new

  • Fixed Ibutton emulation bug #733 (ibutton can only emulate after reading)
  • Fixed the position of the "Repeat code" line on the code input screen
  • Changed the CAME protocol icon.

Verification

  • Look at the code input screen, look at the CAME protocol icon, try emulating the iButton key WITHOUT previous reading.

Checklist (do not modify)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@DrZlo13 DrZlo13 requested a review from skotopes as a code owner December 10, 2021 20:01
@DrZlo13 DrZlo13 marked this pull request as draft December 10, 2021 20:01
@github-actions
Copy link

github-actions bot commented Dec 10, 2021 •
edited
Loading

Click here to flash the 1d3708c0 version of this branch via WebUSB.

@DrZlo13 DrZlo13 changed the title Release 0.42 bugfixes [FL-1891] Release 0.42 bugfixes Dec 10, 2021
@DrZlo13 DrZlo13 marked this pull request as ready for review December 10, 2021 21:42
@anna-oake anna-oake closed this Dec 10, 2021
@anna-oake anna-oake reopened this Dec 10, 2021
skotopes
skotopes previously approved these changes Dec 11, 2021
View reviewed changes
@skotopes skotopes self-requested a review December 11, 2021 13:11
@skotopes skotopes merged commit 58ce937 into dev Dec 12, 2021
@skotopes skotopes deleted the zlo/release-0.42-bugfixes branch December 12, 2021 11:03
vvzvlad pushed a commit to vvzvlad/flipperzero-firmware that referenced this pull request Dec 12, 2021
@DrZlo13 @skotopes @vvzvlad
[FL-1891] Release 0.42 bugfixes (flipperdevices#891)
2b259ec 
* Fixed the "ibutton can only emulate after reading" bug
* Fixed previous fix. FIXES FOR THE FIX GOD! BUGS FOR THE BUG THRONE!
* Fixed "Repeat code" position on code input screen
* Changed CAME protocol icon
* Brewfile: add imagemagick missing assets compiler dependency
* Correct fix for "Repeat code" position on code input screen

Co-authored-by: Aleksandr Kutuzov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skotopes skotopes skotopes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ibutton emulation bug
3 participants
@DrZlo13 @skotopes @anna-oake