Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FL-1815, FL-1851, FL-1856] SubGhz: preparation for certification, add deleting stored signals and rename file in SubGHz app #714

Merged
merged 25 commits into from
Sep 28, 2021

Conversation

Skorpionm
Copy link
Member

@Skorpionm Skorpionm commented Sep 20, 2021

What's new

  • FL-1815 SubGhz: test_packet and test_static DutyCycle <23%
  • FL-1815 SubGhz: test_static max 5 sec in transmission mode
  • FL-1815 SubGhz: prohibiting transmission if it is not within the permitted range for the given region
  • SubGhz: fix GO0 low on last hop transmission
  • FL-1851 SubGhz: preparation for certification, add deleting stored signals in SubGHz app
  • FL-1856 Subghz: fix output a double error if the file cannot be opened
  • SubGhz: add rename file SubGhz app

Verification

  • Compile and upload
  • SubGhz: check transmission on devices with different regional settings

Checklist (do not modify)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@github-actions
Copy link

Please fix following code formatting errors:

./applications/subghz/views/subghz_test_carrier.c:121:51: error: code should be clang-formatted [-Wclang-format-violations]
                    subghz_test_carrier->callback(SubghzTestCarrierEventOnlyRx, subghz_test_carrier->context);
                                                  ^
./applications/subghz/scenes/subghz_scene_receiver_info.c:116:23: error: code should be clang-formatted [-Wclang-format-violations]
                } else{
                      ^
./applications/subghz/scenes/subghz_scene_show_only_rx.c:16:20: error: code should be clang-formatted [-Wclang-format-violations]
    popup_set_text(popup, "This frequency can\nonly be used for RX\nin your region", 38, 40, AlignCenter, AlignBottom);
                   ^
./applications/subghz/scenes/subghz_scene_show_only_rx.c:16:26: error: code should be clang-formatted [-Wclang-format-violations]
    popup_set_text(popup, "This frequency can\nonly be used for RX\nin your region", 38, 40, AlignCenter, AlignBottom);
                         ^
./applications/subghz/scenes/subghz_scene_show_only_rx.c:16:85: error: code should be clang-formatted [-Wclang-format-violations]
    popup_set_text(popup, "This frequency can\nonly be used for RX\nin your region", 38, 40, AlignCenter, AlignBottom);
                                                                                    ^
./applications/subghz/scenes/subghz_scene_show_only_rx.c:16:89: error: code should be clang-formatted [-Wclang-format-violations]
    popup_set_text(popup, "This frequency can\nonly be used for RX\nin your region", 38, 40, AlignCenter, AlignBottom);
                                                                                        ^
./applications/subghz/scenes/subghz_scene_show_only_rx.c:16:93: error: code should be clang-formatted [-Wclang-format-violations]
    popup_set_text(popup, "This frequency can\nonly be used for RX\nin your region", 38, 40, AlignCenter, AlignBottom);
                                                                                            ^
./applications/subghz/scenes/subghz_scene_show_only_rx.c:16:106: error: code should be clang-formatted [-Wclang-format-violations]
    popup_set_text(popup, "This frequency can\nonly be used for RX\nin your region", 38, 40, AlignCenter, AlignBottom);
                                                                                                         ^

You might want to run docker compose exec dev /syntax_check.sh for an auto-fix.

@github-actions
Copy link

Please fix following code formatting errors:

./applications/subghz/scenes/subghz_scene_receiver_info.c:116:23: error: code should be clang-formatted [-Wclang-format-violations]
                } else{
                      ^

You might want to run docker compose exec dev /syntax_check.sh for an auto-fix.

@Skorpionm Skorpionm changed the title Skorp subghz [FL-1815] SubGhz: preparation for certification Sep 20, 2021
@github-actions
Copy link

github-actions bot commented Sep 20, 2021

Click here to flash the 3c018e30 version of this branch via WebUSB.

@Skorpionm Skorpionm marked this pull request as ready for review September 20, 2021 13:37
@Skorpionm Skorpionm changed the title [FL-1815] SubGhz: preparation for certification [FL-1815, FL-1851, FL-1856] SubGhz: preparation for certification, add deleting Stored Signals in SubGHz App Sep 22, 2021
@github-actions
Copy link

Please fix following code formatting errors:

./applications/subghz/scenes/subghz_scene_saved_menu.c:56:10: error: code should be clang-formatted [-Wclang-format-violations]
        } 
         ^

You might want to run docker compose exec dev /syntax_check.sh for an auto-fix.

@Skorpionm Skorpionm changed the title [FL-1815, FL-1851, FL-1856] SubGhz: preparation for certification, add deleting Stored Signals in SubGHz App [FL-1815, FL-1851, FL-1856] SubGhz: preparation for certification, add deleting stored signals in SubGHz app Sep 22, 2021
@Skorpionm Skorpionm changed the title [FL-1815, FL-1851, FL-1856] SubGhz: preparation for certification, add deleting stored signals in SubGHz app [FL-1815, FL-1851, FL-1856] SubGhz: preparation for certification, add deleting stored signals and rename file in SubGHz app Sep 22, 2021
@skotopes skotopes merged commit a8981d3 into dev Sep 28, 2021
@skotopes skotopes deleted the skorp_subghz branch September 28, 2021 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants