Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FL-3933] Pipe #3996

Merged
merged 27 commits into from
Dec 24, 2024
Merged

[FL-3933] Pipe #3996

merged 27 commits into from
Dec 24, 2024

Conversation

portasynthinca3
Copy link
Member

@portasynthinca3 portasynthinca3 commented Nov 12, 2024 •
edited by skotopes
Loading

What's new

  • Duplex pipe primitive that provides bidirectional data transfer and state management
  • Unit tests for the Pipe

Verification

  • Run unit tests

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 12, 2024 •
edited
Loading

Compiled f7 firmware for commit 5deee105:

@portasynthinca3 portasynthinca3 marked this pull request as ready for review November 12, 2024 13:35
@portasynthinca3 portasynthinca3 mentioned this pull request Nov 29, 2024
Open
3 tasks
@portasynthinca3 portasynthinca3 changed the title [FL-3933] FuriPipe [FL-3933] Pipe Dec 20, 2024
skotopes
skotopes requested changes Dec 23, 2024
View reviewed changes
Copy link
Member

@skotopes skotopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check naming, other than that all good

lib/toolbox/pipe.h Outdated Show resolved Hide resolved
@skotopes skotopes marked this pull request as draft December 23, 2024 04:48
@skotopes
Copy link
Member

undraft when ready

@portasynthinca3 portasynthinca3 marked this pull request as ready for review December 23, 2024 10:37
@skotopes skotopes merged commit 5fd4239 into dev Dec 24, 2024
11 checks passed
@skotopes skotopes deleted the portasynthinca3/3933-pipe branch December 24, 2024 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skotopes skotopes skotopes approved these changes

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@hedger hedger Awaiting requested review from hedger hedger is a code owner

@gsurkov gsurkov Awaiting requested review from gsurkov gsurkov is a code owner

@nminaylov nminaylov Awaiting requested review from nminaylov nminaylov is a code owner

@gornekich gornekich Awaiting requested review from gornekich gornekich is a code owner

@Astrrra Astrrra Awaiting requested review from Astrrra Astrrra is a code owner

@Skorpionm Skorpionm Awaiting requested review from Skorpionm Skorpionm is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@portasynthinca3 @skotopes