nfc/clipper:

[ted-logan]

What's new

• Correct the station id for BART station San Leandro
• Fill in the station id for BART station Bay Fair
• Add MUNI station ids for the MUNI's T line "Central Subway" project, which opened three new underground stations in 2022

Verification

• To verify this requires specific rides on San Francisco Bay Area transit with a Clipper card. Maybe @tomholford has been to some of these stations recently since we're now tagging each other in our pull requests :)

• MUNI records only the entering station, and doesn't require tagging off to exit the system or complete a trip. Here's a screenshot viewing my Clipper card record of tagging into Chinatown - Rose Pak Station:

  

  Before my change, this station showed up as "Unknown (001a)"

• Tagging into Union Square / Market Street Station:

  

• Tagging into Yerba Buena/Moscone Station

  

• BART records both the entry and exit stations. Here's a screenshot viewing my Clipper card record of a trip from Bay Fair north one stop to San Leandro:

  

  Before my change, the San Leandro station id was incorrect so the trip was incorrectly reported as starting at San Leandro and ending at "Unknown (0020)".

Checklist (For Reviewer)

• PR has description of feature/bug or link to Confluence/Jira task
• Description contains actions to verify feature/bugfix
• I've built this code, uploaded it to the device and verified feature/bugfix

[tomholford]

@ted-logan Nice work.

Maybe @tomholford has been to some of these stations recently since we're now tagging each other in our pull requests :)

I checked the card, unfortunately there are no records for those BART or Muni stops. Nonetheless, based on both #3937 and #3969, these changes LGTM.