[FL-3909] CLI improvements, part I #3928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
portasynthinca3
requested review from
skotopes,
DrZlo13,
hedger,
gsurkov,
nminaylov and
Skorpionm
as code owners
|
Compiled f7 firmware for commit |
|
PVS-Studio report for commit |
skotopes
requested changes
Oct 6, 2024
skotopes
requested changes
Oct 10, 2024
|
undraft when ready |
skotopes
approved these changes
Oct 14, 2024
RogueMaster
pushed a commit
to RogueMaster/flipperzero-firmware-wPlugins
that referenced
this pull request
Oct 15, 2024
* fix: cli top blinking * feat: clear prompt on down key * feat: proper-er ansi escape sequence handling * ci: fix compact build error * Make PVS happy * style: remove magic numbers * style: review suggestions Co-authored-by: あく <[email protected]>
portasynthinca3
added a commit
that referenced
this pull request
Oct 16, 2024
RogueMaster
added a commit
to RogueMaster/flipperzero-firmware-wPlugins
that referenced
this pull request
Oct 16, 2024
… improvements, part I (flipperdevices#3928)" This reverts commit 05a5cd4.
skotopes
added a commit
that referenced
this pull request
Oct 17, 2024
This reverts commit 0f83141. Co-authored-by: あく <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new
topcommandVerification
topcommand does not visibly clear the entire screen when it refreshesfbtis still able to upload filesRemarks
I originally wanted to utilize escape sequences in the console prompt, but it seems like qFlipper does not like them and gets stuck in a loading state whenever the device is connected. Both Labs and
fbtdeal with a colored>:prompt just fine. I have not tested this with any expansion modules and decided to keep it as-is for now.Checklist (For Reviewer)