Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NFC] Change the plantain last number display from "?" to "X" #3819

Merged
merged 1 commit into from
Aug 2, 2024
Merged

[NFC] Change the plantain last number display from "?" to "X" #3819

merged 1 commit into from
Aug 2, 2024

Conversation

Astrrra
Copy link
Member

@Astrrra Astrrra commented Aug 1, 2024 •
edited by skotopes
Loading

What's new

  • The meaning of the last symbol is now more obvious

Verification

  • Read a plantain card, check that the number matches the card, with the last digit being replaced with X
  • Do the same for a "Two Cities" card

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 1, 2024

Compiled f7 firmware for commit 75db5a02:

@hedger hedger added NFC NFC-related UI Affects UI labels Aug 1, 2024
@skotopes skotopes merged commit 4f46032 into dev Aug 2, 2024
11 checks passed
@skotopes skotopes deleted the astra/plantain-hotfix branch August 2, 2024 06:03
ofabel pushed a commit to ofabel/flipperzero-firmware that referenced this pull request Sep 26, 2024
@Astrrra @ofabel
[NFC] Change the plantain last number display from "?" to "X" (flippe…
af3f820 
…rdevices#3819)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skotopes skotopes skotopes approved these changes

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@hedger hedger Awaiting requested review from hedger hedger is a code owner

@gsurkov gsurkov Awaiting requested review from gsurkov gsurkov is a code owner

@gornekich gornekich Awaiting requested review from gornekich gornekich is a code owner

Assignees
No one assigned
Labels
NFC NFC-related UI Affects UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Astrrra @skotopes @hedger