Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FL-3786] Fixed infinite loop in dictionary attack scene #3686

Merged

Conversation

RebornedBrain
Copy link
Contributor

@RebornedBrain RebornedBrain commented Jun 4, 2024

What's new

  • Previously when choosing 'Unlock with dictionary' several times it required to repeat 'Exit' sequence also several times due to the issue that same scene was added to scene manager multiple times.

Verification

  1. Read MIFARE Classic
  2. Skip dictionary attack
  3. Choose 'More' -> 'Unlock with dictionary'
  4. Goto to step 2

Actual result: It requires to repeat 'Back' operation several times until it will go back to NFC menu
New result: On pressing 'Back' button Flipper will move back to NFC menu

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@hedger hedger added NFC NFC-related Bug labels Jun 5, 2024
@RebornedBrain RebornedBrain marked this pull request as ready for review June 5, 2024 12:17
@skotopes skotopes merged commit 7ff785d into flipperdevices:dev Jun 8, 2024
11 checks passed
@RebornedBrain RebornedBrain deleted the reborned/infinite_dict_attack_fix branch August 19, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug NFC NFC-related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants