Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FL-3815] Fix the retry/exit confirmation prompts in iButton #3613

Merged
merged 1 commit into from
Apr 24, 2024
Merged

[FL-3815] Fix the retry/exit confirmation prompts in iButton #3613

merged 1 commit into from
Apr 24, 2024

Conversation

Astrrra
Copy link
Member

@Astrrra Astrrra commented Apr 24, 2024 •
edited by skotopes
Loading

What's new

  • Read Exit and Retry prompts are now consistent with the other apps and the design doc

Verification

  • Check that the prompts do what is outlined in the doc and FL-3815

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@github-actions GitHub Actions
Copy link

Compiled f7 firmware for commit ac56a2c2:

@Astrrra Astrrra marked this pull request as ready for review April 24, 2024 00:41
@skotopes skotopes merged commit 34abaa7 into dev Apr 24, 2024
11 checks passed
@skotopes skotopes deleted the astra/3815-ibutton-ui-fixes branch April 24, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skotopes skotopes skotopes approved these changes

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@hedger hedger Awaiting requested review from hedger hedger is a code owner

@gsurkov gsurkov Awaiting requested review from gsurkov gsurkov is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Astrrra @skotopes