Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for S(WTX) request in iso14443_4a_poller #3590

Merged
merged 3 commits into from
Apr 19, 2024
Merged

add support for S(WTX) request in iso14443_4a_poller #3590

merged 3 commits into from
Apr 19, 2024

Conversation

leommxj
Copy link
Contributor

@leommxj leommxj commented Apr 15, 2024

What's new

current iso14443_4a_poller_send_block does not handle S(WTX) request, it will end up with a Iso14443_4aErrorProtocol when receive one.
This commit add support for S(WTX) request in iso14443_4a_poller_send_block. The old furi_hal_nfc_tx_rx will handle S(WTX) request normally, it is in the ST25RFAL lib.

see 7.3 Frame waiting time extension in ISO/IEC 14443-4
and
https://github.com/Proxmark/proxmark3/blob/6116334485ca77343eda51c557cdc81032afcf38/armsrc/iso14443a.c#L1961-L1978

Verification

Many ISO14443 Type A cards, like most credit cards, require this support when dealing with time-consuming tasks. Without it, communication will end immediately after receiving the first F2 01 S(WTX).

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@skotopes skotopes added NFC NFC-related New Feature Contains an IMPLEMENTATION of a new feature labels Apr 18, 2024
Copy link
Member

@gornekich gornekich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@skotopes skotopes merged commit 286fd79 into flipperdevices:dev Apr 19, 2024
11 checks passed
@leommxj leommxj deleted the iso14443_4_wtx_support branch April 21, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Feature Contains an IMPLEMENTATION of a new feature NFC NFC-related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants