Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IR: Fix crash on duty_cycle=1 #3568

Merged
merged 3 commits into from
Apr 7, 2024

Infrared: use float around duty_cycle

5e657bc
Select commit
Loading
Failed to load commit list.
Merged

IR: Fix crash on duty_cycle=1 #3568

Infrared: use float around duty_cycle
5e657bc
Select commit
Loading
Failed to load commit list.
Task list completed / task-list-completed succeeded Apr 7, 2024 in 0s

3 / 3 tasks completed

All tasks have been completed

Details

Required Tasks

Task Status
infrared_signal_is_raw_valid() says that duty_cycle > 1 is invalid Incomplete
infrared_worker_set_raw_signal() checks duty_cycle < 1 Incomplete
therefore, duty_cycle == 1 fails the check, when really it should be accepted Incomplete
send an infrared raw with duty_cycle: 1 Incomplete
PR has description of feature/bug or link to Confluence/Jira task Completed
Description contains actions to verify feature/bugfix Completed
I've built this code, uploaded it to the device and verified feature/bugfix Completed