Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move crypto1 to helpers, add it to the public API #3567

Merged
merged 3 commits into from
Apr 7, 2024
Merged

Move crypto1 to helpers, add it to the public API #3567

merged 3 commits into from
Apr 7, 2024

Conversation

Astrrra
Copy link
Member

@Astrrra Astrrra commented Apr 3, 2024 •
edited by skotopes
Loading

What's new

  • Crypto1 now in nfc/helpers instead of nfc/mf_classic because it's useful for other purposes as well
  • Crypto1 now accessible to FAPs

Verification

  • Check that Mifare Classic still works

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 3, 2024 •
edited
Loading

Compiled f7 firmware for commit 48a36264:

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 3, 2024

PVS-Studio report for commit 5790c4cd:

@Astrrra Astrrra marked this pull request as ready for review April 3, 2024 10:58
@Astrrra Astrrra mentioned this pull request Apr 3, 2024
Merged
3 tasks
@CookiePLMonster
Copy link
Contributor

Is prng_successor meant to be public? It's named rather oddly compared to the other public symbols from that file.

@skotopes skotopes merged commit 27e61eb into dev Apr 7, 2024
11 checks passed
@skotopes skotopes deleted the astra/crypto1-api branch April 7, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skotopes skotopes skotopes approved these changes

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@hedger hedger Awaiting requested review from hedger hedger is a code owner

@gsurkov gsurkov Awaiting requested review from gsurkov gsurkov is a code owner

@gornekich gornekich Awaiting requested review from gornekich gornekich is a code owner

@nminaylov nminaylov Awaiting requested review from nminaylov nminaylov is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Astrrra @CookiePLMonster @skotopes