Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fbt: fixed missing FBT_FAP_DEBUG_ELF_ROOT to dist env #3563

Merged
merged 1 commit into from
Apr 2, 2024
Merged

fbt: fixed missing FBT_FAP_DEBUG_ELF_ROOT to dist env #3563

merged 1 commit into from
Apr 2, 2024

Conversation

hedger
Copy link
Member

@hedger hedger commented Apr 2, 2024 •
edited by skotopes
Loading

What's new

Verification

  • Try debugging any .fap using CLI - should work now

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 2, 2024

Compiled f7 firmware for commit 36de2a5c:

@hedger hedger added Bug Build System & Scripts fbt, scripts and toolchain-related labels Apr 2, 2024
@skotopes skotopes merged commit d32f195 into dev Apr 2, 2024
11 checks passed
@skotopes skotopes deleted the hedger/fap_debug_fix branch April 2, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skotopes skotopes skotopes approved these changes

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@gsurkov gsurkov Awaiting requested review from gsurkov gsurkov is a code owner

Assignees
No one assigned
Labels
Bug Build System & Scripts fbt, scripts and toolchain-related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hedger @skotopes