Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fbt: added -Wstrict-prototypes for main firmware #3557

Merged
merged 4 commits into from
Apr 1, 2024
Merged

fbt: added -Wstrict-prototypes for main firmware #3557

merged 4 commits into from
Apr 1, 2024

Conversation

hedger
Copy link
Member

@hedger hedger commented Apr 1, 2024 •
edited by skotopes
Loading

What's new

  • fbt: added -Wstrict-prototypes for main firmware (excludes extapps)
  • removed spammy advertising message from gap

Verification

  • just build the fw

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 1, 2024 •
edited
Loading

Compiled f7 firmware for commit f83e0301:

@hedger hedger added the Build System & Scripts fbt, scripts and toolchain-related label Apr 1, 2024
@hedger hedger changed the title fbt: added -Wstrict-prototypes for main firmware (excludes extapps) fbt: added -Wstrict-prototypes for main firmware Apr 1, 2024
@skotopes skotopes merged commit 096a26b into dev Apr 1, 2024
11 checks passed
@skotopes skotopes deleted the hedger/strict-prototypes branch April 1, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skotopes skotopes skotopes approved these changes

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@gsurkov gsurkov Awaiting requested review from gsurkov gsurkov is a code owner

@nminaylov nminaylov Awaiting requested review from nminaylov nminaylov is a code owner

@gornekich gornekich Awaiting requested review from gornekich gornekich is a code owner

@Astrrra Astrrra Awaiting requested review from Astrrra Astrrra is a code owner

@Skorpionm Skorpionm Awaiting requested review from Skorpionm Skorpionm is a code owner

Assignees
No one assigned
Labels
Build System & Scripts fbt, scripts and toolchain-related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hedger @skotopes