Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IR: Remember OTG state #3549

Merged
merged 2 commits into from
Apr 1, 2024
Merged

IR: Remember OTG state #3549

merged 2 commits into from
Apr 1, 2024

Conversation

Willy-JL
Copy link
Contributor

@Willy-JL Willy-JL commented Mar 29, 2024 •
edited by skotopes
Loading

What's new

  • Infrared will remember OTG/5V on/off
  • It's weird that output pin is remembered but not otg, then the user could configure ext pin with 5v on, close and reopen, now its on gpio but no 5v, so there is no output at all, not from ext and not from int

Verification

  • Set infrared output to pa7 and gpio 5v on
  • Close and reopen app
  • 5v enabled again, module works as expected

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@skotopes skotopes merged commit 9f71be6 into flipperdevices:dev Apr 1, 2024
11 checks passed
@Willy-JL Willy-JL deleted the ir-remember-otg branch April 1, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skotopes skotopes skotopes approved these changes

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@hedger hedger Awaiting requested review from hedger hedger is a code owner

@gsurkov gsurkov Awaiting requested review from gsurkov gsurkov is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Willy-JL @skotopes