Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Troyka parser improvements #3390

Merged
merged 41 commits into from
Mar 5, 2024
Merged

Troyka parser improvements #3390

merged 41 commits into from
Mar 5, 2024

Conversation

assasinfil
Copy link
Contributor

@assasinfil assasinfil commented Jan 23, 2024

What's new

  • Rewrited troyka parser
  • All known Mosgortrans layouts have been added

Verification

  • Try to parse Troyka card and validate result with "Транспортные карты Москвы"

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@assasinfil assasinfil marked this pull request as ready for review January 23, 2024 22:25
@gornekich
Copy link
Member

Thanks for PR!
Please run linter: ./fbt format

Also we will merge this PR after #3365

@gornekich gornekich self-assigned this Jan 25, 2024
@assasinfil assasinfil marked this pull request as draft January 27, 2024 09:39
@assasinfil
Copy link
Contributor Author

Waiting for accept these pr #3386, #3383

@assasinfil assasinfil changed the title Troyka Troyka parser improvements Feb 15, 2024
@assasinfil assasinfil marked this pull request as ready for review February 20, 2024 16:22
@gornekich
Copy link
Member

@assasinfil thanks for update!
I really like adding mosgorrtrans_util to application API. I guess this API will be reused for other plugins, right?

I tested this plugin with some of my cards and it looks good. I think it's a little bit confusing to see other types of cards like "Ediniy" and "TAT" even there is "No ticket". I guess this means that the card is configured the way it can be used as "Ediniy", but there is no ticket yet, right?

@Astrrra could you please test this PR with your cards and leave you feedback?

@assasinfil
Copy link
Contributor Author

@gornekich Other types of cards are actually present in Troyka. Of course, I haven't seen the opportunity to write down a single one for a long time, but there is one for reading old cards)

gornekich
gornekich previously approved these changes Mar 4, 2024
@skotopes skotopes merged commit a6c5a1b into flipperdevices:dev Mar 5, 2024
9 checks passed
@Astrrra Astrrra mentioned this pull request Mar 6, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants