Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FL-3678] NFC UI refactor #3369

Merged
merged 69 commits into from
Jan 16, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
69 commits
Select commit Hold shift + click to select a range
f0838dd
Added new image DolphinSaved_113x58.png for all "saved" pages
RebornedBrain Nov 30, 2023
810dfa1
New image DolphinDone_80x58.png added
RebornedBrain Nov 30, 2023
f7de656
Replaced dolphins on all scenes accroding to new UI specs
RebornedBrain Nov 30, 2023
94cdaf2
New success dolphin image added
RebornedBrain Dec 1, 2023
59e797b
Success scene image replaced
RebornedBrain Dec 1, 2023
7554e7b
Changed image and text for update initial scene
RebornedBrain Dec 1, 2023
fa04e36
Image and text adjusted for "Original restored" scene
RebornedBrain Dec 1, 2023
f151d3b
Removed old DolphinNice_96x59.png image
RebornedBrain Dec 1, 2023
ff724ce
New image for LFRFID scene
RebornedBrain Dec 4, 2023
7af6a46
Removed unused image
RebornedBrain Dec 4, 2023
38b65fb
New UI image added to assets
RebornedBrain Dec 4, 2023
d113bbf
Replaced warning dolphin on mf_classic write initial fail scene
RebornedBrain Dec 4, 2023
278ae51
Removed old image
RebornedBrain Dec 4, 2023
12180ba
Changed image on scenes to a new one
RebornedBrain Dec 4, 2023
18ea05e
New dolphin mafia image
RebornedBrain Dec 5, 2023
064c60e
Replaced dolphin mafia image to a new one
RebornedBrain Dec 5, 2023
fa146d8
Removed DolphinMafia_115x62.png
RebornedBrain Dec 5, 2023
59e9456
New check symbol on completed state for detect_reader
RebornedBrain Dec 6, 2023
f3cbb03
Adjusted layout elements position
RebornedBrain Dec 14, 2023
94e8e5d
Removed second switching to popup view in order to achieve control in…
RebornedBrain Dec 14, 2023
1a56ce7
CardDetected event now also triggers on_event callback
RebornedBrain Dec 14, 2023
04e28f3
Now on AuthRequest we throw CardDetected custom event
RebornedBrain Dec 14, 2023
d7b54df
Added callback for read_on_event
RebornedBrain Dec 14, 2023
69d1d54
Now we show different screen while reading and unlocking
RebornedBrain Dec 14, 2023
cf6829f
Merge branch 'dev' into reborned/nfc_ui_refactor
skotopes Dec 18, 2023
4a77a23
Fixed missing asstes for some scenes
RebornedBrain Dec 18, 2023
d5164c4
Update DolphinMafia_119x62.png
RebornedBrain Dec 19, 2023
5bff5ca
Adjusted all the scenes with DolphinMafia image
RebornedBrain Dec 19, 2023
33136b4
Scenes with save image adjusted
RebornedBrain Dec 19, 2023
3ec0703
Removed unnecessary assets DolphinMafia_119x62.png and DolphinSaved_1…
RebornedBrain Dec 19, 2023
2b3e12f
All common dolphins moved to Dolphin folder
RebornedBrain Dec 20, 2023
09defbc
Moved DolphinReadingSuccess_59x63.png to Dolphin folder
RebornedBrain Dec 20, 2023
e9e44db
Merge branch 'reborned/nfc_ui_refactor' of [email protected]:RebornedBra…
RebornedBrain Dec 21, 2023
3edbf8f
Set proper led color for detect and read scenes
RebornedBrain Dec 28, 2023
d65dfe1
Added new notification sequence for semi_success results
RebornedBrain Dec 28, 2023
305d5bc
Use new sequence for semi_success nfc reads
RebornedBrain Dec 28, 2023
cf4b537
Different events are now throwed depending on read result
RebornedBrain Dec 28, 2023
bf78ace
Added handling of incomplete event for ultralight cards
RebornedBrain Dec 28, 2023
4b36347
Replaced image for iButton scene
RebornedBrain Dec 28, 2023
d55652d
Updated API for f18
RebornedBrain Dec 28, 2023
13fe872
Merge branch 'dev'
RebornedBrain Dec 28, 2023
f4e738a
Merge branch 'dev' into reborned/nfc_ui_refactor_2
gornekich Dec 28, 2023
5994c26
Merge branch 'dev' into reborned/nfc_ui_refactor_2
skotopes Dec 29, 2023
e2a7d5f
Fixed issue with unlock retry sequence
RebornedBrain Dec 29, 2023
82ecc8e
Fix after review
RebornedBrain Dec 29, 2023
0a44c75
Success notification replaced to semi success in case of incomplete m…
RebornedBrain Dec 29, 2023
c9ffe4a
New text for read scene
RebornedBrain Dec 29, 2023
18fbe36
New read result sound notification logic for mf classic cards
RebornedBrain Dec 29, 2023
843fa3e
Merge branch 'dev'
RebornedBrain Jan 10, 2024
1ea99d1
Merge branch 'dev'
RebornedBrain Jan 10, 2024
cfb974d
Change MIFARE name accroding to new requirements
RebornedBrain Jan 10, 2024
686fd20
New QR code image for MFKey app
RebornedBrain Jan 10, 2024
14af1fe
Update nfc_scene_mf_classic_mfkey_complete.c scene according to new U…
RebornedBrain Jan 10, 2024
85f437e
Update detect_reader.c and check_big_20x17.png
RebornedBrain Jan 10, 2024
4397e2c
New nfc save confirm scene added
RebornedBrain Jan 11, 2024
d3c994c
Implemented new flow for 'Detect Reader button' after partial mf clas…
RebornedBrain Jan 11, 2024
bfffaf5
UID for 15693 tags now shown on the new line
RebornedBrain Jan 12, 2024
685ed6b
Fix nfc unit tests
RebornedBrain Jan 12, 2024
01d178a
Merge branch 'dev' into reborned/nfc_ui_refactor_2
gornekich Jan 12, 2024
8799e11
Revert "Fix nfc unit tests"
RebornedBrain Jan 12, 2024
6103de1
Rolled back all Mifare renamings in library files
RebornedBrain Jan 12, 2024
22aba52
Revert "Change MIFARE name accroding to new requirements"
RebornedBrain Jan 12, 2024
321a56d
Now Mifare word is changed only on the app level without changes to l…
RebornedBrain Jan 12, 2024
c539cfa
Merge branch 'dev' into reborned/nfc_ui_refactor_2
skotopes Jan 14, 2024
957a89f
Filename or "Unsaved + CardType" is now showed for saved cards during…
RebornedBrain Jan 15, 2024
be15c5f
Headers added to Write scenes
RebornedBrain Jan 15, 2024
ba6b564
Reordered menu items accrding to new spec
RebornedBrain Jan 15, 2024
f1a9726
Merge commit 'd73d00779788db49d5306f51fb4c789b54568281'
RebornedBrain Jan 15, 2024
cb0cf7b
Merge branch 'dev' into reborned/nfc_ui_refactor_2
skotopes Jan 16, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -391,12 +391,15 @@ static void nfc_protocol_support_scene_saved_menu_on_enter(NfcApp* instance) {
nfc_protocol_support[protocol]->scene_saved_menu.on_enter(instance);

// Trailer submenu items
submenu_add_item(
submenu,
"Info",
SubmenuIndexCommonInfo,
nfc_protocol_support_common_submenu_callback,
instance);
if(nfc_has_shadow_file(instance)) {
submenu_add_item(
submenu,
"Restore to Original State",
SubmenuIndexCommonRestore,
nfc_protocol_support_common_submenu_callback,
instance);
}

submenu_add_item(
submenu,
"Rename",
Expand All @@ -409,15 +412,12 @@ static void nfc_protocol_support_scene_saved_menu_on_enter(NfcApp* instance) {
SubmenuIndexCommonDelete,
nfc_protocol_support_common_submenu_callback,
instance);

if(nfc_has_shadow_file(instance)) {
submenu_add_item(
submenu,
"Restore Data Changes",
SubmenuIndexCommonRestore,
nfc_protocol_support_common_submenu_callback,
instance);
}
submenu_add_item(
submenu,
"Info",
SubmenuIndexCommonInfo,
nfc_protocol_support_common_submenu_callback,
instance);

submenu_set_selected_item(
instance->submenu,
Expand Down Expand Up @@ -582,8 +582,14 @@ static void nfc_protocol_support_scene_emulate_on_enter(NfcApp* instance) {

} else {
widget_add_string_element(widget, 90, 13, AlignCenter, AlignTop, FontPrimary, "Emulating");
furi_string_set(
temp_str, nfc_device_get_name(instance->nfc_device, NfcDeviceNameTypeFull));
if(!furi_string_empty(instance->file_name)) {
furi_string_set(temp_str, instance->file_name);
} else {
furi_string_printf(
temp_str,
"Unsaved\n%s",
nfc_device_get_name(instance->nfc_device, NfcDeviceNameTypeFull));
}
}

widget_add_text_box_element(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,9 @@ static void nfc_scene_mf_classic_write_initial_setup_view(NfcApp* instance) {
scene_manager_get_scene_state(instance->scene_manager, NfcSceneMfClassicWriteInitial);

if(state == NfcSceneMfClassicWriteInitialStateCardSearch) {
popup_set_header(instance->popup, "Writing", 95, 20, AlignCenter, AlignCenter);
popup_set_text(
instance->popup, "Apply the initial\ncard only", 128, 32, AlignRight, AlignCenter);
instance->popup, "Apply the initial\ncard only", 95, 38, AlignCenter, AlignCenter);
popup_set_icon(instance->popup, 0, 8, &I_NFC_manual_60x50);
} else {
popup_set_header(popup, "Writing\nDon't move...", 52, 32, AlignLeft, AlignCenter);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,9 @@ static void nfc_scene_mf_ultralight_write_setup_view(NfcApp* instance) {
scene_manager_get_scene_state(instance->scene_manager, NfcSceneMfUltralightWrite);

if(state == NfcSceneMfUltralightWriteStateCardSearch) {
popup_set_header(instance->popup, "Writing", 95, 20, AlignCenter, AlignCenter);
popup_set_text(
instance->popup, "Apply the initial\ncard only", 128, 32, AlignRight, AlignCenter);
instance->popup, "Apply the initial\ncard only", 95, 38, AlignCenter, AlignCenter);
popup_set_icon(instance->popup, 0, 8, &I_NFC_manual_60x50);
} else {
popup_set_header(popup, "Writing\nDon't move...", 52, 32, AlignLeft, AlignCenter);
Expand Down