Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added UTF-8 support to Flipper Zero canvas API #3297

Merged
merged 4 commits into from
Dec 18, 2023
Merged

Added UTF-8 support to Flipper Zero canvas API #3297

merged 4 commits into from
Dec 18, 2023

Conversation

bolknote
Copy link
Contributor

@bolknote bolknote commented Dec 16, 2023 •
edited by skotopes
Loading

What's new

  • I suggest adding UTF-8 support to canvas API

Verification

  • load cyrillic font: canvas_set_custom_u8g2_font(canvas, u8g2_font_haxrcorp4089_t_cyrillic);
  • draw cyrillic phrase: canvas_draw_str(canvas, 0, canvas_height(canvas) / 2, "АБВ");

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@hedger hedger added UI Affects UI New Feature Contains an IMPLEMENTATION of a new feature Core+Services HAL, furi & core system services labels Dec 17, 2023
skotopes
skotopes previously approved these changes Dec 18, 2023
View reviewed changes
@skotopes
Copy link
Member

Most of the methods in elements library are not ready for unicode.
I'll merge this PR since it's not breaking anything, but more work on elements is needed.

@skotopes skotopes merged commit 25d24f1 into flipperdevices:dev Dec 18, 2023
9 checks passed
@bolknote
Copy link
Contributor Author

bolknote commented Dec 19, 2023 •
edited
Loading

Most of the methods in elements library are not ready for unicode.

Hello! Yes, I am fully aware of this and plan to continue working!

skotopes added a commit that referenced this pull request Dec 22, 2023
@skotopes
Revert "Added UTF-8 support to Flipper Zero canvas API (#3297)"
ae66cec 
This reverts commit 25d24f1.
@skotopes skotopes mentioned this pull request Dec 22, 2023
Merged
3 tasks
skotopes added a commit that referenced this pull request Dec 22, 2023
@skotopes
Rollback #3305 and #3297 fix various rendering issues (#3307)
531ba24 
* Revert "[FL-3729, FL-3730] Gui: fix string width calculation (#3305)"
* Revert "Added UTF-8 support to Flipper Zero canvas API (#3297)"
skotopes added a commit that referenced this pull request Dec 28, 2023
@skotopes
Revert "Rollback #3305 and #3297 fix various rendering issues (#3307)"
9f5a650 
This reverts commit 531ba24.
hedger added a commit that referenced this pull request Mar 19, 2024
@skotopes @hedger
[FL-3729] Gui: unicode support, new canvas API (#3322)
bcde0ae 
* Revert "Rollback #3305 and #3297 fix various rendering issues (#3307)"

This reverts commit 531ba24.

* Gui: refactor canvas to use proper coordinate system types. Furi: new furi_break check macros. Desktop: proper types for negative offset.

* Desktop: proper types in desktop_view_locked_doors_draw

* Examples: update images example, off it goes

---------

Co-authored-by: hedger <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skotopes skotopes skotopes approved these changes

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@hedger hedger Awaiting requested review from hedger hedger is a code owner

Assignees
No one assigned
Labels
Core+Services HAL, furi & core system services New Feature Contains an IMPLEMENTATION of a new feature UI Affects UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bolknote @skotopes @hedger