NfcDict Refactoring

[v0lp3]

What's new

I refactored the NfcDict structure to make it more generic, so now we can use it with other applications like RFID (for example if we implement dictionary attack on T5577's password). The NfcDict was renamed KeysList and was moved into toolbox, therefore MfUserDict wraps this structure.

Verification

Test NFC application.

Checklist (For Reviewer)

• PR has description of feature/bug or link to Confluence/Jira task
• Description contains actions to verify feature/bugfix
• I've built this code, uploaded it to the device and verified feature/bugfix

[skotopes]

@v0lp3 also keep in mind that there are other apps that using nfc dict (picopass) that is going to be broken by those changes

[v0lp3]

@v0lp3 also keep in mind that there are other apps that using nfc dict (picopass) that is going to be broken by those changes

I see. How about we retain the nfc_dict.* files or replace functions in nfc_dict.h with inlines to ensure compatibility?

[skotopes]

@v0lp3 good question, let's wait for @gornekich comment on this PR.

[gornekich]

Please, rename KeysList to KeysDict and rework nfc application with KeysDict. No need to support old symbols. I will rework picopass app to use new KeysDict by my self.

So, the scope of this PR should be moving NfcDict to KeysDict in toolbox

[v0lp3]

Please, rename KeysList to KeysDict and rework nfc application with KeysDict. No need to support old symbols. I will rework picopass app to use new KeysDict by my self.

So, the scope of this PR should be moving NfcDict to KeysDict in toolbox

Ok done

[gornekich]

@v0lp3 please, fix unit tests.
Run ./fbt FIRMWARE_APP_SET=unit_tests to build firmware with unit tests. Then connect to cli via ./fbt cli, run unit_tests nfc and make sure all tests are passed

[v0lp3]

@v0lp3 please, fix unit tests. Run ./fbt FIRMWARE_APP_SET=unit_tests to build firmware with unit tests. Then connect to cli via ./fbt cli, run unit_tests nfc and make sure all tests are passed

How can i configure a mock flipper zero device?

[gornekich]

@v0lp3 please, fix unit tests. Run ./fbt FIRMWARE_APP_SET=unit_tests to build firmware with unit tests. Then connect to cli via ./fbt cli, run unit_tests nfc and make sure all tests are passed

How can i configure a mock flipper zero device?

Don't understand your problem. Do you have flipper to test your changes?

[v0lp3]

@v0lp3 please, fix unit tests. Run ./fbt FIRMWARE_APP_SET=unit_tests to build firmware with unit tests. Then connect to cli via ./fbt cli, run unit_tests nfc and make sure all tests are passed

How can i configure a mock flipper zero device?

Don't understand your problem. Do you have flipper to test your changes?

I was wondering if it is a problem to run unit tests with PR GitHub actions. I read that the device used in the actions is mock and I was asking you if it would be possible to replicate the configuration in my own environment.

[gornekich]

I was wondering if it is a problem to run unit tests with PR GitHub actions. I read that the device used in the actions is mock and I was asking you if it would be possible to replicate the configuration in my own environment.

I see that you fixed unit tests. Running locally unit_tests in CLI is equivalent to CI tests

[gornekich]

Well done, thanks!